fix: unescaped html in block job expiration text #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text was not marked html_safe thus it would render as `Expires <span title="July 12, 2025 19:55">10 minutes ago</span>` instead of `Expires 10 minutes ago` and show an tooltip with the exact time when hovered.
Member
|
Ahh, good catch @elasticspoon! And sorry for the delay. Let me think of an alternative so that we don't have to litter the view as you said. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text was not marked html_safe thus it would render as
Expires <span title="July 12, 2025 19:55">10 minutes ago</span>instead ofExpires 10 minutes agoand show an tooltip with the exact time when hovered.Before:
After:
Note:
Adding
.html_safewithin the helper would not work since you need to mark the whole interpolated string"Expires #{bidirectional_time_distance_in_words_with_title(job.blocked_until)}"as HTML safe.It would be kinda nice to not litter the view with that.